Traduccion de src/controllers/write/categories.js de JS a TS" #16#45
Open
JoseAlfonzo99 wants to merge 4 commits intoUSB-CI3715:f24from
Open
Traduccion de src/controllers/write/categories.js de JS a TS" #16#45JoseAlfonzo99 wants to merge 4 commits intoUSB-CI3715:f24from
JoseAlfonzo99 wants to merge 4 commits intoUSB-CI3715:f24from
Conversation
…laron con npm run lint -- --fix
… exports y los valores de retornos para pasar el run test
Pull Request Test Coverage Report for Build 11317594716Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(resolves #16 ) En el archivo se realizaron los siguientes cambios para hacer una traducción completa de JS a TS:
Se modificaron los imports y exports para que sean acordes a la sintaxis de TypeScript
Se implementaron las interfaces Params,Request,Response, WatchStateRequest
Se agregaron los comentarios // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment,, @typescript-eslint/no-unsafe-member-access para poder ignorar las advertencias de lint ya que se utilizan archivos que no se han traducido
Se arreglaron los errores de identacion
Se uso en los debidos casos el tipado de unknown y así se corrigió el uso de any
Se modifico el archivo tsconfig.json de es6 a es2017.
Las pruebas que se realizaron fueron:
npm run lint, el cual no ocasiono ningún error
npm run test, el cual origina y muestra una cobertura alta y buena